From 1145aad356f67f0de6c606c6db48b58cb7273cda Mon Sep 17 00:00:00 2001 From: Ben Buhse Date: Sat, 28 Feb 2026 15:57:42 -0600 Subject: [PATCH] Remove the wl_output.mode listener wl_output.mode provides the physical dimensions of the output, whereas river_output_v1.dimensions provides the logical dimensions. In general, we use the logical coordinates from the dimensions event except for a few places where we do the scale math on the buffers. So, mode was fairly useless. If I find a need in the future, I can add it back (but not set the output width/height in it). --- src/Output.zig | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/Output.zig b/src/Output.zig index 2db197f..2761afb 100644 --- a/src/Output.zig +++ b/src/Output.zig @@ -269,16 +269,6 @@ fn riverOutputListener(river_output_v1: *river.OutputV1, event: river.OutputV1.E // Used for the wl_output global interface that corresponds to the river_output_v1 fn wlOutputListener(_: *wl.Output, event: wl.Output.Event, output: *Output) void { switch (event) { - .mode => |ev| { - if (ev.width < 0 or ev.height < 0) { - // I'm not actually sure if this is possible, but just to be safe - log.warn("Received wl_output.mode event with a negative width or height ({d}x{d})", .{ ev.width, ev.height }); - return; - } - - output.geometry.width = @intCast(ev.width); - output.geometry.height = @intCast(ev.height); - }, .done => { output.initWallpaperLayerSurface() catch |err| { const output_name = output.name orelse "some output";