steven/csep-2025
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: correct deletion method implementation

Browse source 
reference: https://stackoverflow.com/questions/75912878/could-not-write-json-failed-to-lazily-initialize-a-collection-when-returning-an
This commit is contained in:
Zhongheng Liu 2025-11-22 01:24:04 +01:00
commit 17f4b8bba4
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
server/src/main/java/server/api/RecipeController.java
View file

@ -115,17 +115,16 @@ public class RecipeController {
* Deletes a recipe identified by its <code>id</code>. * Deletes a recipe identified by its <code>id</code>.
* </p> * </p>
* @param id The id of the recipe to be deleted. * @param id The id of the recipe to be deleted.
* @return 200 OK with the recipe that was deleted; or 400 Bad Request if the recipe doesn't exist. * @return 200 OK with true; or 400 Bad Request if the recipe doesn't exist.
*/ */
@DeleteMapping("/recipe/{id}") @DeleteMapping("/recipe/{id}")
public ResponseEntity<Recipe> deleteRecipe(@PathVariable Long id) { public ResponseEntity<Boolean> deleteRecipe(@PathVariable Long id) {
if (!recipeRepository.existsById(id)) { if (!recipeRepository.existsById(id)) {
return ResponseEntity.badRequest().build(); return ResponseEntity.badRequest().build();
} }
Recipe removedRecipe = recipeRepository.findById(id).get(); recipeRepository.deleteById(id);
recipeRepository.delete(removedRecipe);
// TODO: Send WS update to propagate deletion // TODO: Send WS update to propagate deletion
return ResponseEntity.ok(removedRecipe); return ResponseEntity.ok(true);
} }
} }