From 1ad959b2381153f615a1d762fa54b23365a15378 Mon Sep 17 00:00:00 2001
From: Rithvik Sriram <r.sriram-1@student.tudelft.nl>
Date: Thu, 4 Dec 2025 18:09:30 +0100
Subject: [PATCH] fixed pipeline issues

---
 .../src/main/java/client/utils/ConfigService.java   |  3 +--
 .../test/java/client/scenes/ConfigServiceTest.java  | 12 +++++++++---
 client/src/test/java/client/scenes/ConfigTest.java  | 13 ++++++-------
 3 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/client/src/main/java/client/utils/ConfigService.java b/client/src/main/java/client/utils/ConfigService.java
index 0215d74..d1d70c6 100644
--- a/client/src/main/java/client/utils/ConfigService.java
+++ b/client/src/main/java/client/utils/ConfigService.java
@@ -1,8 +1,7 @@
 package client.utils;
 
 
-import com.fasterxml.jackson.core.exc.StreamReadException;
-import com.fasterxml.jackson.databind.DatabindException;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 import java.nio.file.Path;
diff --git a/client/src/test/java/client/scenes/ConfigServiceTest.java b/client/src/test/java/client/scenes/ConfigServiceTest.java
index 31fa0a5..8af3d78 100644
--- a/client/src/test/java/client/scenes/ConfigServiceTest.java
+++ b/client/src/test/java/client/scenes/ConfigServiceTest.java
@@ -19,6 +19,11 @@ import static org.junit.jupiter.api.Assertions.*;
 
 public class ConfigServiceTest {
     static ServerUtils dv = new ServerUtils();
+
+
+    private static final long TEST_ID_A = 23412L;
+    private static final long TEST_ID_B = 25412L;
+
     @BeforeEach
     public void setup(){
         Assumptions.assumeTrue(dv.isServerAvailable(), "Server not available");
@@ -49,8 +54,9 @@ public class ConfigServiceTest {
         assertEquals("http://exmple12.com", config.getServerUrl());
 
         List<Long> x = new ArrayList<>();
-        x.add(23412L);
-        x.add(25412L);
+
+        x.add(TEST_ID_A);
+        x.add(TEST_ID_B);
 
         List<String> y = new ArrayList<>();
         y.add("milk");
@@ -87,4 +93,4 @@ public class ConfigServiceTest {
 
 
 
-}
+}
\ No newline at end of file
diff --git a/client/src/test/java/client/scenes/ConfigTest.java b/client/src/test/java/client/scenes/ConfigTest.java
index d715839..9c82d34 100644
--- a/client/src/test/java/client/scenes/ConfigTest.java
+++ b/client/src/test/java/client/scenes/ConfigTest.java
@@ -13,10 +13,12 @@ import static org.junit.jupiter.api.Assertions.*;
 public class ConfigTest {
     static ServerUtils dv = new ServerUtils();
 
+    private static final long FAV_LIST_ID_1 = 1234L;
+    private static final long FAV_LIST_ID_2 = 1235L;
 
 
     @BeforeEach
-     public void setup(){
+    public void setup(){
         Assumptions.assumeTrue(dv.isServerAvailable(), "Server not available");
     }
 
@@ -40,14 +42,11 @@ public class ConfigTest {
         x.add("Lava Cake");
         x.add("Brownie");
         ArrayList<Long> y = new ArrayList<>();
-        y.add(1234L);
-        y.add(1235L);
+        y.add(FAV_LIST_ID_1);
+        y.add(FAV_LIST_ID_2);
         config.setFavourites(y);
         assertEquals(config.getFavourites(), y);
         config.setShoppingList(x);
         assertEquals(config.getShoppingList(), x);
     }
-
-
-
-}
+}
\ No newline at end of file