Merge branch 'client/fix-inject-httpclient' into 'main'

fix(client): use Guice injection pattern for HttpClient

Closes #59

See merge request cse1105/2025-2026/teams/csep-team-76!53

client/src/main/java/client/MyModule.java

@@ -35,6 +35,7 @@ import com.google.inject.TypeLiteral;
 import commons.Ingredient;
 import commons.Recipe;
 
+import java.net.http.HttpClient;
 import java.nio.file.Path;
 
 public class MyModule implements Module {
@@ -51,6 +52,7 @@ public class MyModule implements Module {
         binder.bind(WebSocketUtils.class).in(Scopes.SINGLETON);
         binder.bind(NutritionDetailsCtrl.class).in(Scopes.SINGLETON);
         binder.bind(NutritionViewCtrl.class).in(Scopes.SINGLETON);
+        binder.bind(HttpClient.class).in(Scopes.SINGLETON);
         binder.bind(ConfigService.class).toInstance(new ConfigService(Path.of("config.json")));
         binder.bind(new TypeLiteral<WebSocketDataService<Long, Recipe>>() {}).toInstance(
                 new WebSocketDataService<>()
@@ -59,4 +61,4 @@ public class MyModule implements Module {
                 new WebSocketDataService<>()
         );
     }
-}
+}

client/src/main/java/client/utils/ServerUtils.java

@@ -32,8 +32,8 @@ public class ServerUtils {
     private final int statusOK = 200;
 
     @Inject
-    public ServerUtils() {
-        client = HttpClient.newHttpClient();
+    public ServerUtils(HttpClient client) {
+        this.client = client;
     }
 
     /**

client/src/test/java/client/ServerUtilsMockTest.java

@@ -12,6 +12,7 @@ import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.net.http.HttpClient;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -40,7 +41,7 @@ class ServerUtilsMockTest {
     @BeforeEach
     void setup() {
         objectMapper = new ObjectMapper();
-        serverUtils = new ServerUtils();
+        serverUtils = new ServerUtils(HttpClient.newHttpClient());
     }
 
     /**

client/src/test/java/client/ServerUtilsTest.java

@@ -11,6 +11,7 @@ import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
+import java.net.http.HttpClient;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.*;
@@ -32,7 +33,8 @@ class ServerUtilsTest {
 
     @BeforeEach
     void setup() throws IOException, InterruptedException {
-        dv = new ServerUtils();
+        // FIXME: Prefer Guice-provided instance via a unit test Module.
+        dv = new ServerUtils(HttpClient.newHttpClient());
 
         Assumptions.assumeTrue(dv.isServerAvailable(), "Server not available");