diff --git a/docs/minutes/week3-meeting-minutes.md b/docs/minutes/week3-meeting-minutes.md index 37b93dc..b873f6b 100644 --- a/docs/minutes/week3-meeting-minutes.md +++ b/docs/minutes/week3-meeting-minutes.md @@ -1,4 +1,4 @@ -# Week 3 meeting agenda +# Week 3 meeting minutes | Key | Value | | ------------ | -------------------------------------------------------- | @@ -8,74 +8,45 @@ | Chair | Steven Liu | | Minute Taker | Oskar Rasieński | | Attendees | Mei Chang van der Werff, Natalia Cholewa, Rithvik Sriram | -## Table of contents -1. (1 min) Introduction by chair -2. (1 min) Any additions to the agenda? -3. (1-2 min) TA announcements? - - Gitlab down on week 5 wednesday till week 6 wednesday. - - Buddy check (brightspace), look for deadline. Give tips, tops and constructive criticism. Follow specific way to do it. -4. (1-2 min) New submission of Code of Conduct + additions? - - We posted it, should be ultra specific. -5. (30 min) **Meeting content** - 1. (2 min) Week 3 progress checklist, MRs, and summary - - Most of 4.1 done - - TODO: integration of all systems. - - TODO: print export week 4. - 2. (3 min) Socket modelling - what do we (don't) want to update with WebSockets - 1. How should we model individual changes, e.g. what happens when the user adds a new recipe? or add an ingredient to a recipe? - - Replace the whole recipe with the new edited recipe - - We have a callback for menus. - 3. (3 min) Discussion on implementing nutritional value calculations - - Don't include informal units in nutritional value calculations. - - Doesn't really matter whether its server side or client side calculated. - 4. (1-2 min) Questions and/or suggestions - 5. (20 min) **Sprint planning week 4** - 1. (2-3 min) Set a provisional deadline for completing parts of the backlog - - week 4: finish 4.1, 4.2 and start 4.3. - 2. (2 min) Confirm week 4 backend/frontend team formation - - Natalia and Ayse Backend, rest frontend - 3. (5 min) Tasks creation (GitLab) and assignment - - In issues and MRs, track time with /spent and /estimate - - If MR doesn't close issue, say its related to an issue with #issuenr - 4. (5 min) Decide on a TODO list that each team should complete before the next meeting (see below for a provisional proposal) - - 5. (5 min) Other issues -6. (2 min) Questions -**Max time:** ~35 minutes -## Addendum -### Provisional week 3 tasks checklist -> May have further additions after the pre-meeting session. +## Announcements +- Gitlab will be down on week 5 wednesday until week 6 wednesday. +- Do Buddy check (brightspace). +## Completed tasks: **Backend**: -- [x] Basic recipe definition -- [x] API endpoints that provide Recipe CRUD functionality -- [x] Unit tests for the endpoints +- Basic recipe definition +- API endpoints that provide Recipe CRUD functionality +- Unit tests for the endpoints **Frontend**: -- [x] A list of recipe names to choose from (Interface) -- [x] An interface to display a recipe when it is chosen from the recipe list -- [ ] (Functional) buttons in the interface -- [x] Server utils (Abstracted requests sending to the backend) +- A list of recipe names to choose from (Interface) +- An interface to display a recipe when it is chosen from the recipe list +- Server utils (Abstracted requests sending to the backend) -- Print exports next week! -- Put server url in config. +## Unfinished tasks: +- Integration of all subsystems. +- print export + +## Teams in week 4: +- Natalia and Ayse: Backend +- Oskar, Steven, Rithvik, Mei: Frontend + +## TODO in week 4: +- Integration of all subsystems. (4.1) +- print export (4.1) +- Websocket (4.2) +- Start with 4.3, and try to do as much as possible. + +## Nutritional Value calculations considerations: +- Don't include informal units in nutritional value calculations. (ignore them and set their value to 0) +- Doesn't really matter whether its server side or client side calculated. + +## Remarks: +- When editing recipes we'll replace the whole recipe with the new edited recipe. +- In issues and MRs, track time with /spent and /estimate +- If MR doesn't close issue, say its related to an issue with #issuenr - Use resource bundles instead of hardcoding text in JFX. +- Put server url in config. -## Provisional week 4 list of tasks -**Backend**: -- 4.2 content - - WebSockets service implementation -- 4.3 content - - implementing actual formal/informal ingredients and appropriate unit class definitions -- ... more to add -**Frontend**: -- Make sure the basic frontend functionality are in place and works as expected -- Improving ingredient/steps editing + deletion to work with the new Ingredient and Unit types -- Making a new scene/view + buttons for the Nutrition view -- Make the interface text ResourceBundle based to implement internationalisation -- ... more to add - -begun: 16:45 -ended: 17:10 -Took 25 mins. \ No newline at end of file +Meeting started: 16:45 and ended: 17:10 (25 mins). \ No newline at end of file