From 4d17f103237dd4543245a8ba1631ef6315e1a5c5 Mon Sep 17 00:00:00 2001
From: Mei Chang van der Werff <m.c.l.werff@student.tudelft.nl>
Date: Thu, 22 Jan 2026 02:15:40 +0100
Subject: [PATCH] updated the port tests to the fixed findFreePort code

---
 .../src/test/java/server/PortCheckerTest.java | 48 +++++++++++--------
 1 file changed, 27 insertions(+), 21 deletions(-)

diff --git a/server/src/test/java/server/PortCheckerTest.java b/server/src/test/java/server/PortCheckerTest.java
index 2843d99..a77e4d9 100644
--- a/server/src/test/java/server/PortCheckerTest.java
+++ b/server/src/test/java/server/PortCheckerTest.java
@@ -31,31 +31,37 @@ class PortCheckerTest {
         }
     }
     @Test
-    void invalidPort(){
-        PortChecker checker = new PortChecker();
-
-        assertThrows(IllegalArgumentException.class, ()-> {
-            checker.isPortAvailable(-1);
-                }
-        );
-        assertThrows(IllegalArgumentException.class, ()-> {
-            checker.isPortAvailable(65536);
-                }
-        );
-    }
-    @Test
-    void findFreePort() throws IOException {
+    void findNotDefaultFreePort() throws IOException {
         PortChecker checker = new PortChecker();
 
         int port = checker.findFreePort();
-        int defaultPort = 8080;
-        int lastPort = 8090;
+        int lowestPossiblePort = 0;
+        int highestPossiblePort = 65535;
 
-        boolean greaterOrEqual = port >= defaultPort;
-        boolean lessOrEqual = port <= lastPort;
-        boolean inRange = greaterOrEqual && lessOrEqual;
-        boolean isItFree = checker.isPortAvailable(port);
+        assertTrue(port > lowestPossiblePort);
+        assertTrue(port <= highestPossiblePort);
+        assertTrue(checker.isPortAvailable(port));
+    }
+    @Test
+    void findDefaultFreePort() throws IOException {
+        PortChecker checker = new PortChecker();
 
-        assertTrue(inRange);
+        boolean free = checker.isPortAvailable(8080);
+
+        assertTrue(free);
+        assertEquals(checker.findFreePort(),8080);
+    }
+
+    @Test
+    void invalidFreePort(){
+        PortChecker checker = new PortChecker();
+
+        assertThrows(IllegalArgumentException.class, () ->
+                checker.isPortAvailable(-1)
+        );
+
+        assertThrows(IllegalArgumentException.class, () ->
+                checker.isPortAvailable(65536)
+        );
     }
 }
\ No newline at end of file