diff --git a/commons/src/test/java/commons/RecipeTest.java b/commons/src/test/java/commons/RecipeTest.java index 97afd8b..138b79c 100644 --- a/commons/src/test/java/commons/RecipeTest.java +++ b/commons/src/test/java/commons/RecipeTest.java @@ -11,21 +11,22 @@ import static org.junit.jupiter.api.Assertions.*; class RecipeTest { Recipe recipe; + final Long RECIPE_ID = 1L; @BeforeEach void setupRecipe() { - this.recipe = new Recipe(1L, "Chocolate Cake"); + this.recipe = new Recipe(RECIPE_ID, "Chocolate Cake"); } @Test void getId() { - assertEquals(1L, recipe.getId()); + assertEquals(RECIPE_ID, recipe.getId()); } @Test void setId() { - recipe.setId(2048L); - assertEquals(2048L, recipe.getId()); + recipe.setId(RECIPE_ID + 1); + assertEquals(RECIPE_ID + 1, recipe.getId()); } @Test @@ -57,7 +58,7 @@ class RecipeTest { recipe.setIngredients(ingredients); assertEquals(recipe.getIngredients(), ingredients); - assertEquals(recipe.getIngredients().size(), 3); + assertEquals(recipe.getIngredients().size(), ingredients.size()); } @Test @@ -76,44 +77,44 @@ class RecipeTest { recipe.setPreparationSteps(steps); assertEquals(recipe.getPreparationSteps(), steps); - assertEquals(recipe.getPreparationSteps().size(), 3); + assertEquals(recipe.getPreparationSteps().size(), steps.size()); } @Test void testEqualsSame() { - Recipe recipe2 = new Recipe(1L, "Chocolate Cake"); + Recipe recipe2 = new Recipe(RECIPE_ID, "Chocolate Cake"); assertEquals(recipe, recipe2); } @Test void testEqualsSameExceptId() { - Recipe recipe2 = new Recipe(2L, "Chocolate Cake"); + Recipe recipe2 = new Recipe(RECIPE_ID + 1, "Chocolate Cake"); assertNotEquals(recipe, recipe2); } @Test void testEqualsOnlySameId() { - Recipe recipe2 = new Recipe(1L, "Some random recipe"); + Recipe recipe2 = new Recipe(RECIPE_ID, "Some random recipe"); assertEquals(recipe, recipe2); // Equals, we only look at ID!!! } @Test void testHashCodeSame() { - Recipe recipe2 = new Recipe(1L, "Chocolate Cake"); + Recipe recipe2 = new Recipe(RECIPE_ID, "Chocolate Cake"); assertEquals(recipe.hashCode(), recipe2.hashCode()); } @Test void testHashCodeSameExceptId() { - Recipe recipe2 = new Recipe(2L, "Chocolate Cake"); + Recipe recipe2 = new Recipe(RECIPE_ID + 1, "Chocolate Cake"); assertNotEquals(recipe.hashCode(), recipe2.hashCode()); } @Test void testHashCodeOnlySameId() { - Recipe recipe2 = new Recipe(1L, "Some random recipe"); + Recipe recipe2 = new Recipe(RECIPE_ID, "Some random recipe"); assertEquals(recipe.hashCode(), recipe2.hashCode()); // Same, only looks at ID!!! }