updated the port tests to the fixed findFreePort code

server/src/test/java/server/PortCheckerTest.java

@@ -31,31 +31,37 @@ class PortCheckerTest {
         }
     }
     @Test
-    void invalidPort(){
+    void findNotDefaultFreePort() throws IOException {
-        PortChecker checker = new PortChecker();
-
-        assertThrows(IllegalArgumentException.class, ()-> {
-            checker.isPortAvailable(-1);
-                }
-        );
-        assertThrows(IllegalArgumentException.class, ()-> {
-            checker.isPortAvailable(65536);
-                }
-        );
-    }
-    @Test
-    void findFreePort() throws IOException {
         PortChecker checker = new PortChecker();
 
         int port = checker.findFreePort();
-        int defaultPort = 8080;
+        int lowestPossiblePort = 0;
-        int lastPort = 8090;
+        int highestPossiblePort = 65535;
 
-        boolean greaterOrEqual = port >= defaultPort;
+        assertTrue(port > lowestPossiblePort);
-        boolean lessOrEqual = port <= lastPort;
+        assertTrue(port <= highestPossiblePort);
-        boolean inRange = greaterOrEqual && lessOrEqual;
+        assertTrue(checker.isPortAvailable(port));
-        boolean isItFree = checker.isPortAvailable(port);
+    }
+    @Test
+    void findDefaultFreePort() throws IOException {
+        PortChecker checker = new PortChecker();
 
-        assertTrue(inRange);
+        boolean free = checker.isPortAvailable(8080);
+
+        assertTrue(free);
+        assertEquals(checker.findFreePort(),8080);
+    }
+
+    @Test
+    void invalidFreePort(){
+        PortChecker checker = new PortChecker();
+
+        assertThrows(IllegalArgumentException.class, () ->
+                checker.isPortAvailable(-1)
+        );
+
+        assertThrows(IllegalArgumentException.class, () ->
+                checker.isPortAvailable(65536)
+        );
     }
 }