steven/csep-2025
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed magic numbers from tests

Browse source
This commit is contained in:
Oskar Rasieński 2025-11-21 20:21:11 +01:00 • committed by Steven Liu
commit a4ec14bfb0
1 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

25
commons/src/test/java/commons/RecipeTest.java
View file

@ -11,21 +11,22 @@ import static org.junit.jupiter.api.Assertions.*;
class RecipeTest { class RecipeTest {
Recipe recipe; Recipe recipe;
final Long RECIPE_ID = 1L;
@BeforeEach @BeforeEach
void setupRecipe() { void setupRecipe() {
this.recipe = new Recipe(1L, "Chocolate Cake"); this.recipe = new Recipe(RECIPE_ID, "Chocolate Cake");
} }
@Test @Test
void getId() { void getId() {
assertEquals(1L, recipe.getId()); assertEquals(RECIPE_ID, recipe.getId());
} }
@Test @Test
void setId() { void setId() {
recipe.setId(2048L); recipe.setId(RECIPE_ID + 1);
assertEquals(2048L, recipe.getId()); assertEquals(RECIPE_ID + 1, recipe.getId());
} }
@Test @Test
@ -57,7 +58,7 @@ class RecipeTest {
recipe.setIngredients(ingredients); recipe.setIngredients(ingredients);
assertEquals(recipe.getIngredients(), ingredients); assertEquals(recipe.getIngredients(), ingredients);
assertEquals(recipe.getIngredients().size(), 3); assertEquals(recipe.getIngredients().size(), ingredients.size());
} }
@Test @Test
@ -76,44 +77,44 @@ class RecipeTest {
recipe.setPreparationSteps(steps); recipe.setPreparationSteps(steps);
assertEquals(recipe.getPreparationSteps(), steps); assertEquals(recipe.getPreparationSteps(), steps);
assertEquals(recipe.getPreparationSteps().size(), 3); assertEquals(recipe.getPreparationSteps().size(), steps.size());
} }
@Test @Test
void testEqualsSame() { void testEqualsSame() {
Recipe recipe2 = new Recipe(1L, "Chocolate Cake"); Recipe recipe2 = new Recipe(RECIPE_ID, "Chocolate Cake");
assertEquals(recipe, recipe2); assertEquals(recipe, recipe2);
} }
@Test @Test
void testEqualsSameExceptId() { void testEqualsSameExceptId() {
Recipe recipe2 = new Recipe(2L, "Chocolate Cake"); Recipe recipe2 = new Recipe(RECIPE_ID + 1, "Chocolate Cake");
assertNotEquals(recipe, recipe2); assertNotEquals(recipe, recipe2);
} }
@Test @Test
void testEqualsOnlySameId() { void testEqualsOnlySameId() {
Recipe recipe2 = new Recipe(1L, "Some random recipe"); Recipe recipe2 = new Recipe(RECIPE_ID, "Some random recipe");
assertEquals(recipe, recipe2); // Equals, we only look at ID!!! assertEquals(recipe, recipe2); // Equals, we only look at ID!!!
} }
@Test @Test
void testHashCodeSame() { void testHashCodeSame() {
Recipe recipe2 = new Recipe(1L, "Chocolate Cake"); Recipe recipe2 = new Recipe(RECIPE_ID, "Chocolate Cake");
assertEquals(recipe.hashCode(), recipe2.hashCode()); assertEquals(recipe.hashCode(), recipe2.hashCode());
} }
@Test @Test
void testHashCodeSameExceptId() { void testHashCodeSameExceptId() {
Recipe recipe2 = new Recipe(2L, "Chocolate Cake"); Recipe recipe2 = new Recipe(RECIPE_ID + 1, "Chocolate Cake");
assertNotEquals(recipe.hashCode(), recipe2.hashCode()); assertNotEquals(recipe.hashCode(), recipe2.hashCode());
} }
@Test @Test
void testHashCodeOnlySameId() { void testHashCodeOnlySameId() {
Recipe recipe2 = new Recipe(1L, "Some random recipe"); Recipe recipe2 = new Recipe(RECIPE_ID, "Some random recipe");
assertEquals(recipe.hashCode(), recipe2.hashCode()); // Same, only looks at ID!!! assertEquals(recipe.hashCode(), recipe2.hashCode()); // Same, only looks at ID!!!
} }