6.7 KiB
Week 6 meeting agenda
| Key | Value |
|---|---|
| Date | Dec 18th |
| Time | 14:45 |
| Location | Hall D |
| Chair | Rithvik Sriram |
| Minute Taker | Mei Chang van der Werff |
| Attendees | Mei Chang van der Werff, Natalia Cholewa, Rithvik Sriram, Aysegul Aydinlik, Steven Liu (online) |
Table of contents
- (Steven joins the meeting online)
- (1 min) Introduction by chair
Meeting starts at 14:46
- (1 min) Any additions to the agenda?
Tomorrow is the deadline for technology, it's best to go over the requirements real quick.
To prevent failing this assignment like the previous 2
- (1-2 min) TA announcements?
If there are any questions about my feedback ask them now
- (1 min) Go over TA feedback given
We've made a little summary of our feedback, and had a few questions
Time Tracking:
- What exactly is expected from us for the time tracking?
We need to do an estimate of how long a task/issue might take. And after implementing it, you have to upload the actual taken time- Are the Mr and issues time tracking connected?
>Yes, but not 100% sure. It's better to double-check it yourselfMilestones:
- What was the exact issue, they are too big?
Our understanding of milestones is wrong, the milestones should be kinda our weekly tasks deadline.
And when we don't finish a task it should be moved to the next milestone, of the next week.UserStory (backlog):
- How should we do this?
You can just put it in the issue description.Don't make it your mr title!
A different groups makes the user story a parent issue and make children issues with the actual code, but we can choose what we wantFor now, we will just put the user Story in the issue description, we will discuss it later if we want to change the method or not
Commit and MR issues:
- Not all commits are related to the Mr
- Our commits are too big, editing ±20 files are way too many. Try too keep it to 3-5 files max.
- Also do only client or only server in a commit, don't combine them.
mvn clean verifybefore pushing to check whether the pipeline fails or not
- (33 min) Meeting content
- (5 min) Week 6 progress in terms of completion
- How far are we in terms of completion?
- 4.1 We still need to merge to connection of the print function, the Mr needed some changes but we can do that later. But do Rebase the MR as the branch is behind with A LOT of commits
- 4.2 We've done the websockets, we only need to merge it
- 4.3 We've done some backend parts but they are not yet connected to the client side
- 4.4 The favourite button and message were made this week
- 4.4 The search bar is currently in prgress on both the client and server side
- 4.5 We keep this for week 8 or next week if there are not enough tasks
Let's focus on just connecting everything next week and after that we can start implementing 4.5
- (5 min) Progress check in terms of feature/issue completion
- What have we completed/going to complete this week?
Rithvik: the backend of the searchbar and favourites is in progress.
Aysegul: Made the favourite button and some UI elements, sadly enough no penguin icon yet :<
Oskar: Finished the websocket implementation, however there is a small TODO left. Steven is going to do that. Also connected the config
Mei Chang: Deleted all the left over example code, made the favourite recipe message(backend), created a test class, made unit use enums and did a small TODO about setters.
Natalia: Almost finished the search bar (frontend) and improved testing on the client side. Will do some refactoring tomorrow.
Steven: Forgot to ask. But did make the language buttons a dropdown box, and did some other things
- (3 min) Small Showcase of the product
We didn't have a lot of time to review and merge our code, so there is not big difference compared to last week.
We've shown the language dropdown box
- (20 min) Sprint planning week 7-8
- What needs to be done?
- Handle Backend-Server code delegation
- How do we do it?
- Who does it?
We didn't really divide the tasks, just the roles. We will distribute tasks on the monday meeting.
We did discuss some things general tasks that need to be doneServer
- Testing
- Refactoring (Oskar)
- Some backend websocket things
- Add more endpoints
Client
- Connecting everything to the UI
- Some frontend websocket things
- (2 min) Designate teams.
There is not a lot of server code that needs to be done so we're keeping the 2/4 server/client distribution this week.
Since there are still 3 people who need their LOC in server they have prioriy
- Ayse and Oskar will do Server
- The others will do Client
- (1 min) Who is the next chair and minute taker?
Mei Chang will be the Chair
Aysegul will be the minute taker
Some Questions
What's the criteria of production code in server?
Answer: recommendation to do 50/50 or 60/40 production/test code.Can we copy code from the internet?
Answer: Yes, but do put the link of where you got the code from in commentsFor a test I want to change the gitlab UI, is that allowed? And I need to write a docx file for this, is the team fine with that?
Answer TA: Yes, but make sure it doesn't affect the other teammates
Team: Yeah we're fine with that
- (2 min) Questions
We haven't yet talked about the technology requirements.
We might didn't split the ui correctly, there is too much logic in it.
Server utils isn't server decoratedWhat is business logic?
Something about the fact that not everything should be in the same file, but split across files
- (1 min) Summarize everything
- 3 people still need to do server LOC; Aysegul, Oskar, Mei Chang.
- Next week our priority is connecting everything
- We need to improve our code contribution and planning based on the feedback
- (1 min) TA remarks
Max time: ~40 minutes
Ta will look at technology on Tuesday
Meeting ends: 15:18
Actual meeting time: 32 minutes